Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zabil
Copy link
Member

@zabil zabil commented Jul 31, 2024

Remove eslint and use biome for formatting a linting to reduce dependencies. Also fix the linting and formatting errors.

Refer #2735

@zabil zabil force-pushed the biome-migration branch from cfb58bf to 4f1417c Compare August 9, 2024 13:10
zabil added 29 commits August 23, 2024 11:07
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Parameter reassignment
foreach loops

Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
zabil added 26 commits August 23, 2024 11:07
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil zabil marked this pull request as ready for review August 23, 2024 10:26
@zabil
Copy link
Member Author

zabil commented Aug 23, 2024

This gigantic PR is ready now. I hope it's ok if I merge this. It is mostly formatting and linting changes. I did some testing and there are no major issues. A few deprecation warning for old node api for example

> (node:6633) [DEP0048] DeprecationWarning: The `util.isError` API is deprecated. Please use `ObjectPrototypeToString(e) === "[object Error]" || e instanceof Error` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Which I feel can be fixed in another PR

@zabil zabil merged commit 0016486 into master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants