-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enhancement: add optional token parameter for gamedig #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added an optional 'token' parameter for services that may call on it for authorization.
Explain new and optional 'token' field required for some authorizations.
Remove defined number type of port variable
Linting fix
Game dig refactor
shamoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but did you test this? It won't actually work without adding the fields to the service helpers...
There are no additional fields to add, is you're referring to the ones I believe you are. The 'gameToken' is required to even show current players for the particular game server that I know you know I added this for. GameDig is pretty consistent with the information that is returned. No additional fields required. Yes, I have tested this, with and without a gameToken. I'll make the changes asap. |
Co-authored-by: shamoon <[email protected]>
Co-authored-by: shamoon <[email protected]>
Not sure we totally understood each other, as written this won't work in homepage because homepage will strip out the |
Fixed incorrectly named service widget reference name token to gameToken.
If you wouldn't mind. Apologies, I'm not sure exactly what you mean. I had no problems during testing. If you don't mind showing me what I'm missing.. Still learning here, thanks for your patience. |
|
No worries, take a look and let me know if you notice anything else, otherwise should be good thanks! |
|
Oh, I see now. 'token' worked but gameToken wouldn't have. I honestly didn't even know those definitions existed. Thank you |
|
It's funny, I dont see the token listed here: https://github.com/gamedig/node-gamedig?tab=readme-ov-file#optional-fields |
It's referenced directly in the satisfactory method. |
|
If you can confirm 'if serviceWidget.gameToken' got changed appropriately. We both missed it initially but it should be correct now. It was still referencing token after the initial change. |
|
yes thanks |
No, thank you for all your help. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Proposed change
Refactor to include optional 'token' key to provide an authorization code to some services that may require it to function fully.
Closes # (issue)
Type of change
Checklist: