Thanks, but I dont believe this does what you think it does.

Docker daemons only speak HTTPS when they're configured with TLS, and the client must provide matching certs — protocol: "https" on its own won't work. Sure, someone can specify https, but this bypasses our existing (correct) TLS guardrails, so in practice:

• Docker will reject this connection
• dockerode will attempt a TLS connection with no certs, and likely fail with a certificate required or self-signed error

Feel free to provide more context.

Please look at the linked discussion. I am running Docker Socket Proxy behind reverse proxy with HTTPS. Without this change Homepage tries to make an API call to DSP using dockerode over HTTP and fails. I understand this is not a typical scenario, but it is a valid scenario, and dockerode supports it through the "https" parameter that I am just "pulling up" into Homepage configuration. I tested it locally.

Thanks!

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.