-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feature: Proxmox status & stats integration #5385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shamoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I see the use here but I need to think about whether we will accept this. I dont really have a way to test it, and as with k8s that has proven to be an issue. I think we can make this work. just need to think about it.
I have some other thoughts / questions about the design here:
- Instead of
proxmox_vmid/proxmox_vmidI think we should use the existingserver/container. Perhaps justproxmox_vmid+container, which would let you differentiate docker vs proxmox. - Following from the above, does
proxmox_typeneed to be set on every instance? Is that not a per-server thing?
Likely will have more, thanks again for your interest in contributing.
Do you have a issue/discussion for this? |
|
I just meant that dealing with k8s issues that come up is challenging because I cant easily test. Yea, I've been messing with getting a proxmox instance setup (on my Mac, yikes) and I understand why you chose to do it this way and about the _type parameter as well. I've got a VM running, LXC giving me grief but should be enough to test this out |
shamoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty solid overall, nothing major here
|
I just used the same token I had created for the widget. There is documentation for that. https://gethomepage.dev/widgets/services/proxmox/ Probably we want to move the instruction for creating a token to https://gethomepage.dev/configs/proxmox (the new page) and reference that from the widget docs. |
ah, gotcha. Yea I do think that'd make more sense |
Co-authored-by: shamoon <[email protected]>
Sounds great. I will implement that. |
shamoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks
|
I want to thank everyone involved on this PR. |
Thanks! I really love contributing to open source projects. I get more appreciation here than at my day job! 😄 |
|
Just for clarification how do you implement this? all im seeing here is how to add it to a widget but where do i define the node itself? |
|
The PR quite literally contains the relevant documentation, did you read it? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Proposed change
This PR adds Proxmox VM and LXC container statistics support to Homepage, similar to the existing Docker and Kubernetes implementations. The feature allows users to monitor CPU usage, memory consumption, and VM/LXC status directly from their Homepage dashboard.
Key Features:
proxmoxvmwidget that displays CPU and memory usage for Proxmox VMs and LXC containersproxmoxTypeparameterImplementation Details:
/api/proxmox/stats/[...service].jsthat fetches VM/LXC status from Proxmox APIProxmoxStatuscomponent for displaying VM status in service cardsProxmoxVMwidget component for detailed statistics displayConfiguration Example:
Closes #1399
Type of change
Checklist:
Files Changed:
src/widgets/proxmoxvm/component.jsx- New widget component for VM statisticssrc/components/services/proxmox-status.jsx- Status indicator componentsrc/pages/api/proxmox/stats/[...service].js- API endpoint for fetching VM statssrc/components/services/item.jsx- Integration with service itemssrc/utils/config/proxmox.js- Proxmox configuration utilities (if applicable)docs/configs/proxmox.md- Updated documentation with new featuressrc/skeleton/proxmox.yaml- Example configuration fileTesting: