ServerSideWebsite: Add Progress.create() arg for Serverless 4 compatibility #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is this backwards compatible with SF v3? |
|
Hi Antony, its basically the same and end user wouldn't notice. [1] https://github.com/serverless/utils/blob/v6.0.0/docs/log.md Cheers, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
With the release of Serverless 4, it appears that the ServerlessUtils
progress.create()method now requires an initial argument to be passed. This is causing issues during deployment and any other time theuploadAssets()function is called.Steps to Reproduce:
uploadAssetsfunction.progress.create().Proposed Fix: Update the
uploadAssets()function in ServerSideWebsite to pass an initial argument toprogress.create()as follows:Current Code Reference:
lift/src/constructs/aws/ServerSideWebsite.ts
Line 242 in 08772c5
Documentation:
https://www.serverless.com/framework/docs/guides/plugins/cli-output#interactive-progress
Solves serverless/serverless#12797
Cheers,
Noah