Feature/typescript #677
Open
Feature/typescript #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55b97b5 to
9baf6f7
Compare
Tom-V
reviewed
May 3, 2025
| // If the container was created or destroyed => perform a watch | ||
| if (action === 'destroy' || action === 'create') { | ||
| await this.watchCronDebounced(); | ||
| this.watchCronDebounced!(); |
There was a problem hiding this comment.
I think I broke something, just not sure yet how exactly, the function can be null right now.
Suggested change
| this.watchCronDebounced!(); | |
| this.watchCronDebounced?.(); |
There was a problem hiding this comment.
I've been using WUD with typescript in an own branch with this small fix, not seeing anything else broken because of this. Is there any other reason not merging this in? More changes means making it more difficult to merge later again.
Once this typescript branch is merged, I will push some more fixes/improvements :) And as said it will allow more people to easier understand how it all works and improve WUD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.