Feature/#451 customizable registry url #781
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve registry lookup feature with full image path support
This builds on @manfred-martin 's original implementation from PR #454 (which was closed without merging).
His work introduced the
wud.registry.lookup.url
label to help users bypass Docker registry caches when checking for updates.Closes #451
Background
Since PR #454 was created, the codebase has moved forward a few versions. This PR merges the original feature branch with version 8.1.1 to bring it up to date with the latest stable release.
However, while testing the original URL-based approach with my Harbor registry setup, I discovered a fundamental issue for my usecase: it doesn't work with registries that use project prefixes or nested paths.
The Problem
The original implementation accepted registry URLs like
https://registry-1.docker.io
and tried to extract the image name from them. This breaks with registries like Harbor, where images look like:The
dockerhub-proxy/
part is a Harbor project name, not part of the actual image name.The URL-based approach would incorrectly include it as part of the image path, causing registry matching to fail. This same problem affects other registries that use hierarchical project structures.
My Solution and Changes
Instead of accepting registry URLs and trying to parse them, accept full image paths directly. While this requires typing the full image path (which may be slightly longer than just a URL), it's more explicit and generic, works with any registry structure, and lets users specify exactly what upstream image WUD should check for updates.
What Changed
wud.registry.lookup.url
towud.registry.lookup.image
library/traefik
orghcr.io/user/image
)Example Usage
This allows WUD to check registries like Docker Hub for traefik updates while the container continues pulling from the Harbor proxy cache, solving the original issue where proxy registries don't have up-to-date tag information.
Testing
Breaking Changes
This changes the label name from
wud.registry.lookup.url
towud.registry.lookup.image
. However, since PR #454 was never merged into a release, this shouldn't affect any users that are not using the feature/#451_customizable_registry_url branch.