Remove increment/decrement buttons for disabled input #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparison of lighthouse reports:
|
|
Re-ping @oponder |
oponder
reviewed
Mar 11, 2019
| input:disabled | ||
| // to hide the increment/decrement buttons when disabled | ||
| -moz-appearance: textfield | ||
| background-color: #fff |
There was a problem hiding this comment.
is this background color right? Quickly tested the branch and it looks ok. But the background-color: #fff is being overruled, so it actually does nothing, and if it would do something, I think it would look odd.
oponder
approved these changes
Mar 11, 2019
|
Comparison of lighthouse reports:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/giantswarm/giantswarm/issues/5469
In Firefox, with the number picker being disabled, the input field would contain two tiny increment/decrement buttons.
This PR hides the buttons and aligns he appearance with Chrome.