Refactor openevec to base actions on top of type and fix multiple configs #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to refactor the logic to use base type for all exported openevec actions Signed-off-by: Petr Fedchenkov <[email protected]>
To use controller config options directly from config we should implement several functions Signed-off-by: Petr Fedchenkov <[email protected]>
To use the same semantic in openevec we should use the same base type. Also we use novel changers to load config directly Signed-off-by: Petr Fedchenkov <[email protected]>
adcad5f to
c448924
Compare
Let's use simple scenario where we want to create several EVE-OS instances in different configs Signed-off-by: Petr Fedchenkov <[email protected]>
In case of delete it would be nice to not show fatal errors Signed-off-by: Petr Fedchenkov <[email protected]>
c448924 to
5fd567e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the same semantic in openevec we should use the same base type.
Also we use novel changers to load config directly to be able to load config directly from openevec