Fix issue where copyHeaderKeepingStructure doesn't work correctly under certain conditions #235
Conversation
09e450d to
033306c
Compare
.swiftlint.yml
Outdated
| warning: 400 | ||
| identifier_name: | ||
| max_length: | ||
| warning: 45 |
There was a problem hiding this comment.
This change is due to the identifier "clangPackageWithRelativePublicHeadersPath" exceeding the maximum allowed length. Its length is 42 characters.
There was a problem hiding this comment.
Default value of this is 40. The modified value is still lower than the default error value so should be okay.
https://realm.github.io/SwiftLint/identifier_name.html
There was a problem hiding this comment.
Could you update https://github.com/giginet/Scipio/blob/main/Tests/.swiftlint.yml instead for test targets?
There was a problem hiding this comment.
I have moved the rule to Tests/.swiftlint.yml in 8e95b49
…ge to FrameworkModuleMapGeneratorTests
.swiftlint.yml
Outdated
| warning: 400 | ||
| identifier_name: | ||
| max_length: | ||
| warning: 45 |
There was a problem hiding this comment.
Default value of this is 40. The modified value is still lower than the default error value so should be okay.
https://realm.github.io/SwiftLint/identifier_name.html
Co-authored-by: IKEDA Sho <[email protected]>
When includeDir contained components like "." or "..", the path was previously used without being standardized.
This caused incorrect behavior in the logic that extracts subdirectories, such as this line:
Scipio/Sources/ScipioKit/Producer/PIF/FrameworkBundleAssembler.swift
Lines 103 to 109 in 07c313d
Standardizing the fileURL resolves this issue by ensuring consistent path handling.