Update ProcessExecutor to support environment variables #232
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
reviewed
Aug 1, 2025
giginet
reviewed
Aug 1, 2025
Comment on lines
+125
to
+127
| if let environment { | ||
| process.environment = environment | ||
| } |
There was a problem hiding this comment.
[nits] It's enough to be
Suggested change
| if let environment { | |
| process.environment = environment | |
| } | |
| process.environment = environment |
There was a problem hiding this comment.
I don't think so. Setting the property explicitly to nil will not mean ineheriting the current process environment, rather it may clear out the environment. We should be careful about this behavior.
If this method isn’t used, the environment is inherited from the process that created the receiver.
There was a problem hiding this comment.
I checked the implementation in swift-corelibs-foundation. If the property is nil ProcessInfo.processInfo.environment is used, so setting nil explicitly will be safe.
However, I still prefer not to set the property if it's not needed.
ikesyo
approved these changes
Aug 4, 2025
giginet
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an environment parameter to ProcessExecutor to support executing processes with custom environment variables.
This change enables use of ScipioKit in custom build pipelines that require specific environment configurations.