Forward of the headers in the HTTPExceptions #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordi Riera <[email protected]>
This was referenced Dec 11, 2025
Collaborator
|
Can I ask how this is different from #226 ? |
Author
|
I noted that the kwargs are not passed as an argument in some exceptions, like |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 474 475 +1
Branches 78 78
=========================================
+ Hits 474 475 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jordi Riera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, the HTTP headers are available in the HTTPException and its subclasses. It exposes the response context. We have this need at Autodesk because we hit GitHub's secondary rate limit. We want to use the header details to configure an optimized retry policy when we hit this limit.
We hit some 429 from GitHub due to secondary rate limit. The way to handle that, following the GitHub guidance, is to check the headers headers, which the library blocks. This PR works on this.
related to
RateLimit.from_http()isNone#207