Adding pageSize option #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main focus of this PR is to introduce a maximum pageSize for each subarray. This means that if a person sets the pageSize to be 6 in their options, each click of a tab will limit itself to displaying 6 options.
Other small changes:
Limiting the description to 140 chars as per new bower warning https://minetest-bower.herokuapp.com/docs/bower-format
Some error handling, which stops javascript errors appearing when there are no items (thus stopping other javascript on the page it appears from executing, this was causing troubles using the plugin with the Drupal panels in place editor).