Fixed open local file-url issue (file:///) #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue described in #65 - tabox is unable to open any local file URLs e.g. file:///test.txt
The issue resides in chrome/background.js
When "Discard tabs on open" is enabled, deferredLoading.html will try and load the URL. However, this file cannot access local file URLs e.g. file:/// protocol, and will throw this error: "Not allowed to load local resource", forever keeping the tab in the deferredLoading.html page.
The fix: In order to fix the issue, we can check if the tab URL starts with "file:///", and if it's true, we can have it so that "deferredLoading.html?url=" is not used, and just 'tabInGrp.url' is loaded.