Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add basic wallet hooks #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2025
Merged

feat: add basic wallet hooks #270

merged 5 commits into from
Sep 24, 2025

Conversation

@nickfrosty
Copy link
Collaborator

@nickfrosty nickfrosty commented Sep 16, 2025 •
edited
Loading

Summary of Changes

add basic wallet functionality by reexporting the wallet standard packages

Fixes #289

Note: In the future we will add the additional hooks and reactivity to tie everything together in a more cohesive way. This is groundwork for that.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8394fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@gillsdk/react Minor
@gillsdk/examples-basics Minor
@gillsdk/examples-tokens Minor
@gillsdk/tests-e2e Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bundlemon
Copy link

bundlemon bot commented Sep 16, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ react/dist/index.browser.mjs
 1.84KB (+53B +2.89%) -
✅ react/dist/index.native.mjs
 1.84KB (+52B +2.84%) -
✅ react/dist/index.node.mjs
 1.84KB (+52B +2.84%) -
Unchanged files (13)
Status Path Size Limits
✅ gill/dist/programs/index.node.mjs
 9.83KB -
✅ gill/dist/index.browser.mjs
 5.19KB -
✅ gill/dist/index.native.mjs
 5.19KB -
✅ gill/dist/programs/token/index.node.mjs
 4.09KB -
✅ solana-pay/dist/index.browser.mjs
 1.72KB -
✅ solana-pay/dist/index.native.mjs
 1.72KB -
✅ solana-pay/dist/index.node.mjs
 1.72KB -
✅ gill/dist/node/index.node.mjs
 947B -
✅ gill/dist/index.node.mjs
 488B -
✅ svelte/dist/index.browser.mjs
 265B -
✅ vue/dist/index.browser.mjs
 265B -
✅ svelte/dist/index.node.mjs
 262B -
✅ vue/dist/index.node.mjs
 262B -

Total files change +157B +0.41%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@catmcgee catmcgee linked an issue Sep 16, 2025 that may be closed by this pull request
Expose kit and wallet-standard hooks #289
Closed
catmcgee
catmcgee approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@catmcgee catmcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you update description so it doesnt close #251?

the team made this issue to address exactly what you said here - In the future we will add the additional hooks and reactivity to tie everything together in a more cohesive way

you can close this one instead :D #289

@tobeycodes
Copy link
Collaborator

tobeycodes commented Sep 17, 2025 •
edited
Loading

@nickfrosty @catmcgee I think we will also need @wallet-standard/ui as there are some types we most likely want to reuse https://github.com/wallet-standard/wallet-standard/tree/master/packages/ui/_

Also, @solana/wallet-standard-chains for detecting if a wallet supports Solana https://github.com/anza-xyz/wallet-standard/blob/4f6248e90581f0032553eb4dbdd8bdee65342f8e/packages/core/chains/src/index.ts#L29

@nickfrosty
Copy link
Collaborator Author

@nickfrosty @catmcgee I think we will also need @wallet-standard/ui as there are some types we most likely want to reuse https://github.com/wallet-standard/wallet-standard/tree/master/packages/ui/_

Also, @solana/wallet-standard-chains for detecting if a wallet supports Solana https://github.com/anza-xyz/wallet-standard/blob/4f6248e90581f0032553eb4dbdd8bdee65342f8e/packages/core/chains/src/index.ts#L29

makes sense, i will add them

@nickfrosty nickfrosty merged commit 91a3ac2 into master Sep 24, 2025
6 checks passed
@nickfrosty nickfrosty deleted the wallets-basics branch September 24, 2025 14:03
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
@nickfrosty nickfrosty mentioned this pull request Sep 24, 2025
Open
Shubbu03 pushed a commit to Shubbu03/gill that referenced this pull request Oct 3, 2025
@nickfrosty @Shubbu03
feat: add basic wallet hooks (gillsdk#270)
c96fcf1 
* feat: add wallet hooks

* chore: typecheck command

* feat: add wallet standard

* feat: add packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catmcgee catmcgee catmcgee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose kit and wallet-standard hooks

3 participants

@nickfrosty @tobeycodes @catmcgee