feat!: derive Copy on TuiWidgetEvent and TuiLoggerLevelOutput#55
Merged
gin66 merged 1 commit intogin66:masterfrom Feb 4, 2024
Merged
feat!: derive Copy on TuiWidgetEvent and TuiLoggerLevelOutput#55gin66 merged 1 commit intogin66:masterfrom
Copy on TuiWidgetEvent and TuiLoggerLevelOutput#55gin66 merged 1 commit intogin66:masterfrom
Conversation
These enums are small and simple enough to be `Copy`. This change simplifies calling code to not have to use `&` when passing or comparing these enums. See https://doc.rust-lang.org/std/marker/trait.Copy.html#when-should-my-type-be-copy for justification. BREAKING CHANGE: `TuiWidgetEvent::transition()` method now takes a `TuiWidgetEvent` by value instead of by reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These enums are small and simple enough to be
Copy. This changesimplifies calling code to not have to use
&when passing orcomparing these enums.
See https://doc.rust-lang.org/std/marker/trait.Copy.html#when-should-my-type-be-copy
for justification.
BREAKING CHANGE:
TuiWidgetEvent::transition()method now takes aTuiWidgetEventby value instead of by reference.