Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generate methods with typed records as out parameter (non-nullable, no transfer) #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

Generate methods with typed records as out parameter (non-nullable, no transfer) #1324

merged 1 commit into from
Sep 26, 2025

Conversation

@ousnius
Copy link
Contributor

@ousnius ousnius commented Sep 21, 2025

  • Only non-nullable out parameters without ownership transfer for now
  • Nullable out-parameters don't make much sense in C# in the traditional way
  • Added new native test
  • Fixed a few typos

See #1120, #1191 and #932 to see what part of them is solved by this.

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@badcel
Copy link
Member

badcel commented Sep 25, 2025

A general information: The available annotations are documented here.

badcel
badcel reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic work! Great job it's exactly like I would have done it.

My comments are only minor things which are not absolutely needed, but will probably help later on during development.

@ousnius @badcel
Generate methods with typed records as out parameter (non-nullable, n…
0ad168f 
…o transfer)

* Only non-nullable out parameters without ownership transfer for now
* Added new native test
* Fixed a few typos

Co-Authored-By: Marcel Tiede <[email protected]>
@ousnius ousnius force-pushed the typed-records-out-parameter branch from 30934f6 to 0ad168f Compare September 25, 2025 20:33
@ousnius ousnius marked this pull request as ready for review September 25, 2025 20:34
This was referenced Sep 25, 2025
Closed
Closed
This was linked to issues Sep 26, 2025
can't get text iterators from a TextBuffer #1191
Closed
record parameter with direction != in not yet supported. #1120
Closed
@badcel badcel merged commit 3506b46 into gircore:main Sep 26, 2025
3 checks passed
@ousnius ousnius deleted the typed-records-out-parameter branch September 26, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badcel badcel badcel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

can't get text iterators from a TextBuffer record parameter with direction != in not yet supported.

2 participants

@ousnius @badcel