Add Pango CSS scale factor constants #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why the constants are not generated? See: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/567 |
|
Can you please put the calculation into the code, instead of the result? It will still be a constant expression and the compiler will use full precission for calculations. |
0.5787037037037 -> 0.5787037037037037 |
|
Can you squash and it's good to go 🚀. |
See header pango-font.h * Pango.Constants.XX_SMALL * Pango.Constants.X_SMALL * Pango.Constants.SMALL * Pango.Constants.MEDIUM * Pango.Constants.LARGE * Pango.Constants.X_LARGE * Pango.Constants.XX_LARGE Change Pango scale factors to expressions for full precision Example values: 0.5787037037037 -> 0.5787037037037037 0.6944444444444 -> 0.6944444444444444 0.8333333333333 -> 0.8333333333333334
8ea19c7 to
91fdfeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See header https://gitlab.gnome.org/GNOME/pango/-/blob/main/pango/pango-font.h#L261
Other wrappers like GtkSharp or Vala have also introduced these as custom code.
e.g. https://gitlab.gnome.org/GNOME/vala/-/blob/main/vapi/metadata/Pango-1.0-custom.vala