main: fix incorrect proxy detection in KDE when proxy is disabled globally#1453
Merged
davvid merged 2 commits intogit-cola:mainfrom Jan 18, 2025
Merged
Conversation
…bally When the proxy is disabled globally in the System Settings in KDE the proxy host and address settings may still be preserved in the kioslaverc/Proxy Settings/*Proxy configuration settings. Check the kioslaverc/Proxy Settings/httpProxy setting's value and return None when it is not set to "1"(meaning that the "Use manually specified proxy configuration" mode isn't selected). Fixes git-cola#1452. Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the proxy is disabled globally in the System Settings in KDE the proxy host and address settings may still be preserved in the kioslaverc/Proxy Settings/*Proxy configuration settings.
Check the kioslaverc/Proxy Settings/httpProxy setting's value and return None when it is not set to "1"(meaning that the "Use manually specified proxy configuration" mode isn't selected).
Fixes #1452.