Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alpreu
Copy link

@alpreu alpreu commented Oct 10, 2017

Created a new PR as explained by @pedrorijo91 in #1030. Thanks for your help πŸ‘

@pedrorijo91
Copy link
Member

pedrorijo91 commented Oct 10, 2017

as discussed on #1030 (comment), we will try to ping the original authors (using git blame) and perhaps the tools developers so that they can have a chance to respond

fixes #381

@pedrorijo91
Copy link
Member

pedrorijo91 commented Oct 10, 2017

git blame is not very useful due to b9b5595, had to check the file history (https://github.com/git/git-scm.com/commits/master/app/views/downloads/guis/index.html.haml) .

guis (from https://git-scm.com/downloads/guis):

gui blame author username has reviewed?
sourcetree
github desktop Croydon y
tortoiseGit csware y
gitkraken smith-kyle y
gitup swisspol y
smartgit
git extensions
tower gntr y
gitg cveneziani y
gitX-dev welladamm
aurees ychetyrko
git-cola
ungit zigarn y
gitbox kheyse
Cycligent Git Tool tylerc y
GitEye markphip y
Fork DanPristupov y
GitAhead hackhaslam y
giggle cveneziani
codeReview FabriceSalvaire y

some guis have missing authors because it were imported by Scott at the beginning.

I think I will just make them a mention in the next comment, asking for a review

@pedrorijo91
Copy link
Member

to: @Croydon @csware @smith-kyle @swisspol @gntr @cveneziani @welladamm @ychetyrko @zigarn @kheyse @tylerc @markphip @DanPristupov @hackhaslam @FabriceSalvaire

Hey,

As many of you may know, the git-scm website lists many git GUI tools under https://git-scm.com/downloads/guis

As discussed in #381 , we pretend to add license information to the listed GUI tools. @alpreu made an awesome contribution by gathering the data in this PR. We thought you guys may wanted to have a look before merging this.

Let us know if any question arises! :)

@swisspol
Copy link
Contributor

Looks good, thanks!

@pedrorijo91
Copy link
Member

I decided to email/slack/irc a few to try getting faster answers. On one side it's a problem because it's not public info (it's on my email, maybe I should have cc git mailing list...), on the other side, I think there's no big problem. If someone eventually disagrees, it just needs to raise an issue/PR and we will take of it quickly

@pedrorijo91 pedrorijo91 self-assigned this Oct 11, 2017
@pedrorijo91 pedrorijo91 self-requested a review October 11, 2017 21:59
@tylerchurch
Copy link

Cycligent Git Tool developer here - LGTM!

@nacho
Copy link

nacho commented Oct 12, 2017

Gitg looks good to me

@samuelherzog
Copy link

Tower Team here: Great PR & Info is fine - Thanks!

@peff
Copy link
Member

peff commented Oct 12, 2017

Thanks for putting together the table, @pedrorijo91. For the last few that don't have a reviewed entry, it's pretty easy to turn up their licenses:

all of which match the contents of the PR. So I think we are good here. Thanks everyone for your responses!

@peff peff merged commit d204d78 into git:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants