-
Notifications
You must be signed in to change notification settings - Fork 1.3k
adding license information to gui clients page #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
as discussed on #1030 (comment), we will try to ping the original authors (using git blame) and perhaps the tools developers so that they can have a chance to respond fixes #381 |
|
git blame is not very useful due to b9b5595, had to check the file history (https://github.com/git/git-scm.com/commits/master/app/views/downloads/guis/index.html.haml) . guis (from https://git-scm.com/downloads/guis):
some guis have missing authors because it were imported by Scott at the beginning. I think I will just make them a mention in the next comment, asking for a review |
|
to: @Croydon @csware @smith-kyle @swisspol @gntr @cveneziani @welladamm @ychetyrko @zigarn @kheyse @tylerc @markphip @DanPristupov @hackhaslam @FabriceSalvaire Hey, As many of you may know, the git-scm website lists many git GUI tools under https://git-scm.com/downloads/guis As discussed in #381 , we pretend to add license information to the listed GUI tools. @alpreu made an awesome contribution by gathering the data in this PR. We thought you guys may wanted to have a look before merging this. Let us know if any question arises! :) |
|
Looks good, thanks! |
|
I decided to email/slack/irc a few to try getting faster answers. On one side it's a problem because it's not public info (it's on my email, maybe I should have cc git mailing list...), on the other side, I think there's no big problem. If someone eventually disagrees, it just needs to raise an issue/PR and we will take of it quickly |
|
Cycligent Git Tool developer here - LGTM! |
|
Gitg looks good to me |
|
Tower Team here: Great PR & Info is fine - Thanks! |
|
Thanks for putting together the table, @pedrorijo91. For the last few that don't have a reviewed entry, it's pretty easy to turn up their licenses:
all of which match the contents of the PR. So I think we are good here. Thanks everyone for your responses! |
Created a new PR as explained by @pedrorijo91 in #1030. Thanks for your help π