forked from memgraph/memgraph
-
Couldn't load subscription status.
- Fork 0
Add execution model based on Execute/Next/Emit #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gitbuda
wants to merge
72
commits into
project-pineapples
Choose a base branch
from
add-new-execution-model
base: project-pineapples
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dummy physical plan generator * dummy physical operators * few basic comments / reasoning
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
Phase 1 - Basic PoC
EmitandNextONCE,SCAN ALL,PRODUCE(mocks)SingleThreadphysical operator executionFramephysical operatorsFramevsSingleThreadphysical operator executionMultiThreadedExecutorbased on ExecuteAsyncFramevsSingleThreadvsParallelphysical operator executionDataPool::PoolStateto be composable + implement call skips when possible (insideExecutor)Phase 2 - Proof it works in the long run
UnwindandCreateVertices(state objects + execution)Executorthrow in all non-linear cases (e.g.OPTIONAL MATCHnot supported)ONCESCAN ALLCREATE NODE(write, WITH accumulate)UNWIND(multiframe expansion)PRODUCEv1andv2oftests/manual/interactive/*CREATE EXPAND(write, WITH accumulate)EXPAND(basic graph DB operator)VARIABLE EXPAND(graph traversals)FILTER(multiframe reduction)WITH(aggregation)OPTIONAL MATCH(double branch query plan)MERGE(triple branch query plan)CancelTimeoutShutdownPhase 3 - Implement the whole query engine
NOTE: Migrated from memgraph#640