Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Broken getSha and repo.write #147

@gmaclennan

Description

@gmaclennan

This is currently broken by all the merged pull requests from 11 days ago.

I think it is a problem with the Accept header being set to 'application/vnd.github.v3.raw+json' in #105 but the improved Sha functions etc. from #144 rely on the Accept header being 'application/json' in @darvin commit, but should probably be 'application/vnd.github.v3+json'

However, this change would mean that responses to repo.read with return json with the content base64 encoded, and would break the test on repo.read.

I'm a little confused about how to fix it, since this seems to be a result of different pull requests taking different approaches which are incompatible.

There should also be a test for basic functionality such as writing or updating a file - I'm surprised no one has noticed this breaking change with the new version.

Sorry I can't write a test and help more. It's taken me about 3 hours just trying to understand what is going on and why things are broken now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions