Use _requestAllPages for search endpoints
#302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi. Thank you for the PR. This is a good change and because it might break quite a few things, I'd rather have it for version 1.0. Any thoughts @clayreimann @Aendrew? |
Member
|
@AurelioDeRosa I don't think this is liable to break code, but if you'd rather hold off then that's fine. I also think that in general PRs should not bump the package version. |
Author
|
Removed the package version and changelog additions |
Member
|
@chrisronline This was just released in v1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the all search endpoints to use
_requestAllPagesinstead of_requestto support getting the full set of results.My concern is how the flattening process should work - the result set is an array of responses instead of a single response. However, my change does not break tests since it seems the tests do not care about the nature of the response object.
How do you recommend I proceed with this?
Thanks