Fixed Repo.move() and added test #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/Repository.js
Contributor
Author
|
Should squash the commits when merging. |
Member
|
Thanks @cripplet. I'll get this out today or tomorrow. Note to me: this is a breaking change. |
Member
|
@cripplet This is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo.move()previously was broken and did not work as intended; this is a fix for this issue.Repo._updateTree()Repo.commit()docs: as per https://developer.github.com/v3/git/commits/#create-a-commit, argtreeis a SHA string previously created (viaRepo.createTree()), not the tree object itself.Repo.updateHead()API: addedforcearg to match Github API docs (https://developer.github.com/v3/git/refs/#update-a-reference).Repo.updateTree(): previously referenced inRepo.move(); this has been addressed.Repo.move()test: assert moved file has same contents, assert old path does not exist after update.