Fix remote logging output to correctly show snapshot being restored #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/ghe-backup
Outdated
|
|
||
| # Log backup start message in /var/log/syslog on remote instance | ||
| ghe_remote_logger "Starting backup from $(hostname) in snapshot $GHE_SNAPSHOT_TIMESTAMP ..." | ||
| ghe_remote_logger "Starting backup from $(hostname) / snapshot $GHE_SNAPSHOT_TIMESTAMP ..." |
There was a problem hiding this comment.
I think it's clearer with "in". With the slash it looks like backing up from hostname/snapshot.
|
Clearly a bug, so 👍. Can we log failure as well? |
|
Replacing |
Sure, sounds like a good approach for now. I have revered these to their original format. |
|
LGTM, 🚢! |
snh
added a commit
that referenced
this pull request
Feb 25, 2016
Fix remote logging output to correctly show snapshot being restored
cjonsmith
pushed a commit
that referenced
this pull request
Sep 22, 2020
Adds support for backing up Actions files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR fixes the remote logging output so that it correctly shows the snapshot being used for the restore. It currently incorrectly outputs a timestamp of when the restore started rather than that of the snapshot being used.
Also incorporates a couple of minor tweaks to the wording of the remote logging messages to make them consistent.
/cc @github/backup-utils