Check home directory for configuration file #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # and then falling back to the system location. | ||
| config_found=false | ||
| for f in "$GHE_BACKUP_CONFIG" "/etc/github-backup-utils/backup.config"; do | ||
| for f in "$GHE_BACKUP_CONFIG" "$HOME/github-backup-utils/backup.config" "/etc/github-backup-utils/backup.config"; do |
There was a problem hiding this comment.
In my experience, it'd be fairly standard behaviour for a config file in a user's home directory to override the settings in a system config file. Given that, would it be an idea to switch the order of the $HOME/github-backup-utils/backup.config and /etc/github-backup-utils/backup.config files in this loop?
EDIT: I hadn't seen the break that follows, later in the code 😊
|
@snh using a hidden dir is perhaps a bit more common ( |
|
@rubiojr 👍 |
|
👍 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra supported location for the backup config.
backup-utils will attempt to load the backup configuration from the following locations, in this order:
$GHE_BACKUP_CONFIG(User configurable)$GHE_BACKUP_ROOT/backup.config(Root directory of backup-utils install)$HOME/.github-backup-utils/backup.config(New)/etc/github-backup-utils/backup.configThis is useful for situations where the user running backup-utils does not have write access to the install location or
/etc, and does not wish to set an environment variable. Users of the Debian package are the main target audience for this PR./cc @github/backup-utils