Add permissions to GitHub actions workflows, update actions versions #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyan
approved these changes
Dec 8, 2025
There was a problem hiding this comment.
Pull request overview
This pull request enhances the security and maintainability of GitHub Actions workflows by adding explicit permissions blocks and updating action versions. It also modernizes the Go version management by reading from go.mod instead of hardcoding, and updates the deprecated --rm-dist flag to --clean for GoReleaser v2+ compatibility.
Key changes:
- Added minimal permissions blocks to both workflows (write for releases, read for CI)
- Updated GitHub action versions to v6 across all workflows
- Changed Go version strategy from hardcoded 1.19 to using
go.modfile (which specifies 1.20)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Added contents: write permission, updated all action versions to v6, switched to reading Go version from go.mod, and changed goreleaser flag to --clean |
.github/workflows/main.yml |
Added contents: read permission and updated checkout action from @master to @v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix two of the code scanning issues found:
Missing permissions block in the GitHub actions workflows.
It also updates the versions of the used GitHub actions and uses the
go.modfile to determine the Go version for the release workflow.The
--rm-distflag for goreleaser has been deprecated in favor of--cleanand was removed in v2. (docs)