Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Aug 4, 2022

Description

This PR merges the following downstream PRs that add support for zero in dates:

  1. Support zero date and zero in date, via dedicated command line flag openark/gh-ost#31
  2. Support tables with existing zero dates openark/gh-ost#32

Summary:

Allows the user to make schema changes that include a zero date or zero in date (e.g. adding a datetime default '0000-00-00 00:00:00' column), even if global sql_mode on MySQL has NO_ZERO_IN_DATE,NO_ZERO_DATE.

Tweaks I made:

  • Removed ignore_versions file for MySQL 5.5 and 5.6 as they're no longer tested
  • Pin golangci-lint version to match script/lint, their update today caused a problem - fix later

Thank you @shlomi-noach for the code! 👋

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt marked this pull request as ready for review August 5, 2022 00:04
@timvaillancourt timvaillancourt requested review from a user and rashiq August 5, 2022 00:05
@timvaillancourt timvaillancourt added this to the v1.1.6 milestone Aug 5, 2022
@timvaillancourt timvaillancourt merged commit bee009b into github:master Aug 10, 2022
@timvaillancourt timvaillancourt deleted the allow-zero-in-dates branch August 10, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants