Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Remove project requirement #108

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Remove project requirement #108

merged 6 commits into from
Aug 19, 2020

Conversation

@primetheus
Copy link
Contributor

@primetheus primetheus commented Aug 18, 2020 •
edited
Loading

Closes #106

Proposed Changes

  • Remove requirement for projects to be defined in config

The current config requires the definition of a project

rally:
  projects:
    - Project 1
    - Project 2
  workspace: 12345

This pull request allows the following settings as well

rally:
  projects: 
    - Any
  workspace: 12345
rally:
  projects: []
  workspace: 12345
rally:
  workspace: 12345

Readiness Checklist

  • If this change requires documentation, it has been included in this pull request

Reviewer Checklist

  • If a functional change has occurred, testing the integration has been performed
  • This PR has been categorized with a label (1 of automation, bug, documentation, enhancement, infrastructure, or performance) for the changelog

@primetheus primetheus added the enhancement New feature or request label Aug 18, 2020
@primetheus primetheus mentioned this pull request Aug 18, 2020
Closed
admiralAwkbar
admiralAwkbar reviewed Aug 19, 2020
View reviewed changes
lib/RallyValidate.js
if (config.rally.api_key) { // Rally API key, to override global default
rallyAPIKey = config.rally.api_key
}
if (!config.rally.projects || config.rally.projects.length < 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much improvment.. such wow

admiralAwkbar
admiralAwkbar approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@primetheus primetheus merged commit 69c50e3 into main Aug 19, 2020
@primetheus primetheus deleted the primetheus/project-config branch August 19, 2020 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@migarjo migarjo Awaiting requested review from migarjo

@steffen steffen Awaiting requested review from steffen

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

1 more reviewer

@admiralAwkbar admiralAwkbar admiralAwkbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rally.yml "projects" property cannot be omitted (commented out) w/out causing a failure

3 participants

@primetheus @admiralAwkbar