This repository was archived by the owner on Feb 13, 2023. It is now read-only.
fix: commentOnPull #252
Merged
fix: commentOnPull #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkoppert
reviewed
Apr 15, 2021
rally.yml
Outdated
|
|
||
| # Comment on the PR in addition to the check message? (true | false) | ||
| commentOnPull: false | ||
| commentOnPull: true |
There was a problem hiding this comment.
@primetheus Should this default be true or would you rather it default to false?
There was a problem hiding this comment.
@zkoppert this should be false by default. The reason it's present is because older versions of GHES don't have the Checks API and there won't be a place for these results to be posted. In those cases, users can opt for having the results posted as comments to the PR. I don't think that's the desired default though
|
@vorobievalex Thanks for contributing! 🎉 Do you have a screenshot you can share that shows that it commented on a PR? |
zkoppert
reviewed
Apr 16, 2021
|
@zkoppert, sure, here is a screenshot of a comment. |
Co-authored-by: Zack Koppert <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
commentOnPull()used.artifact()and.github.artifactsthat do not exist incontextin probot v9.14.1.pull_request.synchronizeflowReadiness Checklist
Reviewer Checklist
automation,bug,documentation,enhancement,infrastructure, orperformance) for the changelog