-
Notifications
You must be signed in to change notification settings - Fork 75
[WIP] Add gpg signerverifier #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af37d1f to
37000a4
Compare
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
5 similar comments
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
4 similar comments
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
|
Base branch main has been updated to 0b1a751, older reviews (if any) do not apply anymore. |
Signed-off-by: Yongjae Chung <[email protected]>
Signed-off-by: Yongjae Chung <[email protected]>
Signed-off-by: Yongjae Chung <[email protected]>
Signed-off-by: Yongjae Chung <[email protected]>
62300e9 to
0b74be4
Compare
Kusari Analysis ResultsAnalysis for commit: 4d205f5, performed at: 2025-06-03T18:27:05Z Recommendation: ✅ PROCEED with this Pull Request Summary✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters. No pinned version dependency changes, code issues or exposed secrets detected! |
Signed-off-by: Yongjae Chung <[email protected]>
|
Kusari PR Analysis rerun based on - 4ed1b9d performed at: 2025-06-03T18:27:05Z - link to updated analysis |
internal/signerverifier/gpg/gpg.go
Outdated
| } | ||
|
|
||
| // FIXME: trying to import gitinterface causes circular dependency | ||
| func getKeyIDFromGitConfig(r *Repository) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to use code from gitinterface here, but it doesn't allow it because gitinterface already depends on signerverifier.
Signed-off-by: Yongjae Chung <[email protected]>
|
Kusari PR Analysis rerun based on - 662b095 performed at: 2025-06-10T19:15:37Z - link to updated analysis |
Signed-off-by: Yongjae Chung <[email protected]>
|
Kusari PR Analysis rerun based on - 4d205f5 performed at: 2025-06-11T16:42:36Z - link to updated analysis |
@patzielinski