Add duplicate check for PropagationDirectives #1127
Merged
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongjae354
reviewed
Oct 20, 2025
yongjae354
reviewed
Oct 20, 2025
yongjae354
reviewed
Oct 20, 2025
yongjae354
reviewed
Oct 20, 2025
There was a problem hiding this comment.
Hey @dennisshey, thanks for the PR! I left a few comments.
Also just make sure to resolve the linter errors - you can do it manually or use gofmt.
Thanks!
There was a problem hiding this comment.
Thanks for the PR, @dennisshey!!
I've left a comment on @yongjae354's comment about duplicate checks. After that's addressed, I think this should be good to go.
Please also squash commits to 1 commit after making the changes, thanks!!
Signed-off-by: dennisshey <[email protected]>
patzielinski
approved these changes
Oct 23, 2025
|
Observed review from patzielinski+70954403 (@patzielinski) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a duplicate check for PropagationDirective objects added to repository metadata, addressing issue #788.