Thanks to visit codestin.com
Credit goes to github.com

Skip to content

*: Fix remoteRefName bug and spelling nits #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+4 −4
Merged

*: Fix remoteRefName bug and spelling nits #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/git-remote-gittuf/curl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func handleCurl(ctx context.Context, repo *gittuf.Repository, remoteName, url st
The helper has two commands, in reality: list, list
for-push. Both of these are used to list the states of refs
on the remote. The for-push variation just formats it in a
way that can be used for the push comamnd later.
way that can be used for the push command later.

We inspect this to learn we're in a push. We also use the
output of this command, implemented by git-remote-https, to
Expand Down
4 changes: 2 additions & 2 deletions internal/gitinterface/references.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func (r *Repository) AbsoluteReference(target string) (string, error) {
remoteRefName := RemoteReferenceName(target)
_, err = r.GetReference(remoteRefName)
if err == nil {
return branchName, nil
return remoteRefName, nil
}
if !errors.Is(err, ErrReferenceNotFound) {
return "", err
Expand All @@ -158,7 +158,7 @@ func (r *Repository) AbsoluteReference(target string) (string, error) {
remoteRefHEAD := path.Join(remoteRefName, "HEAD")
_, err = r.GetReference(remoteRefHEAD)
if err == nil {
return branchName, nil
return remoteRefHEAD, nil
}
if !errors.Is(err, ErrReferenceNotFound) {
return "", err
Expand Down
2 changes: 1 addition & 1 deletion internal/policy/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ func (v *PolicyVerifier) VerifyNetwork(ctx context.Context) error {
}

// gittuf stores the controller metadata in a subdirectory in the policy
// ref that includes b64 encoded cntroller repo location
// ref that includes b64 encoded controller repo location
encodedLocation := base64.URLEncoding.EncodeToString([]byte(rootMetadata.GetRepositoryLocation()))

controllerPath := fmt.Sprintf("%s/%s-%s", tuf.GittufControllerPrefix, declaredControllerName, encodedLocation)
Expand Down