Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added support for opening submodules in tab instead of separate window #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Added support for opening submodules in tab instead of separate window #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8931982
Added support for opening submodules in tab instead of separate windo…
plan44 Dec 6, 2017
6c9517a
Merge branch 'master' into MR/open-in-tab-support
plan44 Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions Classes/Controllers/PBGitSidebarController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,31 @@ - (void)openSubmoduleFromMenuItem:(NSMenuItem *)menuItem

- (void)openSubmoduleAtURL:(NSURL *)submoduleURL
{
[[NSDocumentController sharedDocumentController] openDocumentWithContentsOfURL:submoduleURL
display:YES
completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError *error) {
if (error) {
[self.windowController showErrorSheet:error];
}
}];
NSWindow *currentWindow = [[NSApplication sharedApplication] keyWindow];
NSEvent *theEvent = [[NSApplication sharedApplication] currentEvent];
BOOL openInTab = (theEvent && [theEvent modifierFlags] & NSEventModifierFlagOption)!=0;
[[NSDocumentController sharedDocumentController] openDocumentWithContentsOfURL:submoduleURL
display:YES
completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError *error) {

if (error) {
[self.windowController showErrorSheet:error];
}
else if (!documentWasAlreadyOpen) {
if (@available(macOS 10.13, *)) {
if (openInTab) {
// move into a tab of the original window
if (currentWindow) {
NSWindow *myWindow = [[document.windowControllers firstObject] window];
if (myWindow) {
NSWindowTabGroup *tabGroup = currentWindow.tabGroup;
[tabGroup addWindow:myWindow];
}
}
}
}
}
}];
}

#pragma mark NSOutlineView delegate methods
Expand Down