Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: starttls and ldaps now matching features #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

feat: starttls and ldaps now matching features #458

merged 2 commits into from
Aug 4, 2025

Conversation

@Fusion
Copy link
Collaborator

@Fusion Fusion commented Aug 3, 2025

This PR handles a few things:

  • application of the patch by @hth2, allowing LDAP to only accept secure ciphers and TLS >= 1.2
  • Alessandro's starttls introduction, 2 years ago (already?!)
  • fixing above patch as there was confusion between starttls and ldaps code
  • making sure both functionalities can be configured similarly
  • couple minor logic things
  • backward compatibility: cert and key configuration can now represent content, or file path (legacy)
  • backward compatibility: legacy configuration parameter, allowing all ciphers/TLS1.0 (but don't!)

@Fusion
Copy link
Collaborator Author

Fusion commented Aug 3, 2025

@shipperizer need review. Please confirm this does not break starttls for your use cases.

@Fusion Fusion mentioned this pull request Aug 3, 2025
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

shipperizer
shipperizer approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fusion Fusion merged commit d68c78a into master Aug 4, 2025
7 of 8 checks passed
@Fusion Fusion mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shipperizer shipperizer shipperizer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fusion @shipperizer