fix: check if HTMLElement is valid in iframe or window #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrzejchalubek
requested changes
May 31, 2024
| } | ||
|
|
||
| if (r !== null) { | ||
| if (exist(r)) { |
There was a problem hiding this comment.
Hmm looks like this check is problematic in general. In this case, I would be opting to just remove entirely this conditional and fully rely on runtime error. This check was only intended to give some sort of more user-friendly message instead of "Something is undefined" it can be removed
There was a problem hiding this comment.
That will do for your user case?
|
Should be fixed with v3.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a fix that was introduced in PR #669, however it didn't fully fix the issue as there were other elements which checked for the validity of a HTML element without using query selector.
This PR reverts back to the use of the original
exist()function but checks to see whether the element exists in the iframe window or within the main window