Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Invalid direction pattern #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Invalid direction pattern #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1775318
feat(run): Warn about invalid direction pattern
jedrzejchalubek Apr 20, 2019
2939e42
fix(): Import missing warn function
jedrzejchalubek Apr 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/components/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,13 @@ export default function (Glide, Components, Events) {
let settings = Glide.settings
let item = controls[Glide.index]

item.classList.add(settings.classes.activeNav)
if (item) {
item.classList.add(settings.classes.activeNav)

siblings(item).forEach(sibling => {
sibling.classList.remove(settings.classes.activeNav)
})
siblings(item).forEach(sibling => {
sibling.classList.remove(settings.classes.activeNav)
})
}
},

/**
Expand All @@ -90,8 +92,10 @@ export default function (Glide, Components, Events) {
* @return {Void}
*/
removeClass (controls) {
if (controls[Glide.index]) {
controls[Glide.index].classList.remove(Glide.settings.classes.activeNav)
let item = controls[Glide.index]

if (item) {
item.classList.remove(Glide.settings.classes.activeNav)
}
},

Expand Down
5 changes: 5 additions & 0 deletions src/components/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { warn } from '../utils/log'
import { define } from '../utils/object'
import { toInt, isNumber } from '../utils/unit'

Expand Down Expand Up @@ -94,6 +95,10 @@ export default function (Glide, Components, Events) {
case '=':
Glide.index = steps
break

default:
warn(`Invalid direction pattern [${direction}${steps}] has been used`)
break
}
},

Expand Down
15 changes: 15 additions & 0 deletions tests/functional/go.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@ describe('Calling `go()` method with', () => {
document.body.innerHTML = html
})

test('invalid direction pattern should result in `warn()` message', (done) => {
let glide = new Glide('#glide')
let fn = jest.fn()

global.console = { error: fn }

glide.mount().go('??')

afterTransition(() => {
expect(fn).toHaveBeenCalled()

done()
})
})

test('`>` should move one slide forward', (done) => {
let { slides } = query(document)

Expand Down