Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 15, 2022. It is now read-only.

Conversation

@rtsao
Copy link
Contributor

@rtsao rtsao commented Jan 20, 2015

This test demonstrates that #100 is still an issue.

@rtsao
Copy link
Contributor Author

rtsao commented Jan 21, 2015

Build should fail due to failed test

@glittershark
Copy link
Owner

Thanks for this!

@glittershark glittershark merged commit a617c74 into glittershark:master Jan 27, 2015
glittershark added a commit that referenced this pull request Jan 27, 2015
Since we're parsing data out of all the React node children that are
passed to the Table, we lose all of the metadata (such as props) that
are applied to those children. In this case, the data object is
actually a meta-object containing the data and the props, and signified
by a `__reactableMeta: true` property.

This probably still needs to be done for the Tds as well.

Fixes #103
@glittershark
Copy link
Owner

I fixed this. Thanks again for the tests!

glittershark added a commit that referenced this pull request Jan 27, 2015
- Make regular HTML props propagate to child React nodes (#103, #100)
  (thanks @rtsao, @akshayp, @EvanBurchard)
glittershark added a commit that referenced this pull request Jan 28, 2015
Using the same strategy as in #103 (a meta-object containing the actual
value, the props, and `__reactableMeta: true`), pass through HTML props
to rendered Tds.

Fixes #107
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants