This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Adds on onKeyDown handler to Th to sort on enter #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, sweet! thanks! |
glittershark
added a commit
that referenced
this pull request
Mar 1, 2016
Adds on onKeyDown handler to Th to sort on enter
|
👍 ! |
glittershark
added a commit
that referenced
this pull request
Mar 1, 2016
+ Add onKeyDown handler to Th to allow screen readers and other browsers to sort on a press of Enter (#248)
|
Just pushed version 0.12.4 with this change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, really happy with the a11y features of this component so far.
I noticed that the
tabindex="0"+role="button"attributes on<th>elements is working really inconsistently across browsers and screen readers to trigger sorting from the keyboard. Also, tab focus + hitting enter doesn't work at all when the screen reader is turned off, which isn't necessarily an a11y concern, but a little surprising given that it can receive tab focus like buttons and links.This implements an
onKeyDownhandler in the<Thead>component that triggersthis.props.onSortwhen the key pressed is theenterkey. I was able to reuse the existing behavior fromhandleClickThin addition to checking which key was pressed.This solution works across browsers with or without a screen reader, which I think is an overall improvement to the interface.