Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove hosts validators #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bdice merged 2 commits into from
Aug 9, 2021
Merged

Remove hosts validators #596

bdice merged 2 commits into from
Aug 9, 2021

Conversation

@bdice
Copy link
Member

@bdice bdice commented Aug 6, 2021 •
edited
Loading

Description

Removes [hosts] section from signac configuration.

I made some internal functions private. We could probably be more aggressive with making functions private in a later pass through the code base.

Motivation and Context

Resolves issue #590. See that issue for details.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice self-assigned this Aug 6, 2021
@bdice bdice added the requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x. label Aug 6, 2021
@bdice bdice added this to the v2.0.0 milestone Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #596 (60def1d) into next (579800d) will decrease coverage by 0.24%.
The diff coverage is 93.75%.

❗ Current head 60def1d differs from pull request most recent head 7a8b479. Consider uploading reports for the commit 7a8b479 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next     #596      +/-   ##
==========================================
- Coverage   84.76%   84.51%   -0.25%     
==========================================
  Files          52       53       +1     
  Lines        5264     5276      +12     
  Branches      964      974      +10     
==========================================
- Hits         4462     4459       -3     
- Misses        587      602      +15     
  Partials      215      215
Impacted Files Coverage Δ
signac/__main__.py 75.17% <0.00%> (ø)
signac/contrib/utility.py 51.88% <ø> (-16.61%) ⬇️
signac/common/config.py 80.55% <100.00%> (+13.26%) ⬆️
signac/common/validate.py 100.00% <100.00%> (+60.86%) ⬆️
signac/contrib/project.py 86.22% <100.00%> (ø)
signac/contrib/linked_view.py 83.91% <0.00%> (-4.24%) ⬇️
signac/contrib/schema.py 95.48% <0.00%> (-0.76%) ⬇️
signac/contrib/collection.py 83.82% <0.00%> (-0.61%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579800d...7a8b479. Read the comment docs.

Base automatically changed from remove-project-index to next August 6, 2021 16:23
@bdice bdice marked this pull request as ready for review August 6, 2021 16:23
@bdice bdice requested review from a team as code owners August 6, 2021 16:23
@bdice bdice force-pushed the remove-hosts-validators branch from 60def1d to 7a8b479 Compare August 9, 2021 14:13
@bdice bdice enabled auto-merge (squash) August 9, 2021 14:14
@bdice bdice merged commit b07f230 into next Aug 9, 2021
@bdice bdice deleted the remove-hosts-validators branch August 9, 2021 14:42
@bdice bdice mentioned this pull request Aug 9, 2021
Closed
vyasr pushed a commit that referenced this pull request Nov 9, 2021
@bdice @vyasr
Remove hosts validators (#596)
1712b95 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
bdice added a commit that referenced this pull request Dec 5, 2021
@bdice
Remove hosts validators (#596)
72ae02b 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Dec 25, 2021
@bdice @vyasr
Remove hosts validators (#596)
790f12f 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Jan 4, 2022
@bdice @vyasr
Remove hosts validators (#596)
327472d 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Jan 27, 2022
@bdice @vyasr
Remove hosts validators (#596)
5c02cdc 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Feb 4, 2022
@bdice @vyasr
Remove hosts validators (#596)
9d5478d 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
@bdice @vyasr
Remove hosts validators (#596)
818c40a 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
@bdice @vyasr
Remove hosts validators (#596)
4a301e2 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Mar 14, 2022
@bdice @vyasr
Remove hosts validators (#596)
efc51dc 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Apr 19, 2022
@bdice @vyasr
Remove hosts validators (#596)
6fdcd24 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Apr 21, 2022
@bdice @vyasr
Remove hosts validators (#596)
cfbacc1 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request May 2, 2022
@bdice @vyasr
Remove hosts validators (#596)
058df52 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
bdice added a commit that referenced this pull request Jun 14, 2022
@bdice
Remove hosts validators (#596)
0646bc4 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
bdice added a commit that referenced this pull request Aug 1, 2022
@bdice
Remove hosts validators (#596)
02c8bfc 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
bdice added a commit that referenced this pull request Oct 7, 2022
@bdice
Remove hosts validators (#596)
1c95d97 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
bdice added a commit that referenced this pull request Oct 27, 2022
@bdice
Remove hosts validators (#596)
f97a730 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
vyasr pushed a commit that referenced this pull request Oct 30, 2022
@bdice @vyasr
Remove hosts validators (#596)
3d4d1f4 
* Remove hosts sections from config validator.

* Remove password validators and file permission handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csadorf csadorf csadorf approved these changes

@tcmoore3 tcmoore3 Awaiting requested review from tcmoore3

@jennyfothergill jennyfothergill Awaiting requested review from jennyfothergill

Assignees

@bdice bdice

Labels

requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x.

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bdice @csadorf