Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove warnings module. #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vyasr merged 2 commits into from
Sep 18, 2022
Merged

Remove warnings module. #815

vyasr merged 2 commits into from
Sep 18, 2022

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 18, 2022

Description

Removes the SignacDeprecationWarning (long unused, we should use FutureWarning instead) and the warnings module, which is now empty.

Motivation and Context

Cleanup for 2.0

Checklist:

@vyasr vyasr added this to the v2.0.0 milestone Sep 18, 2022
@vyasr vyasr self-assigned this Sep 18, 2022
@vyasr vyasr requested review from a team as code owners September 18, 2022 16:11
@vyasr vyasr requested review from pepak13 and tcmoore3 and removed request for a team September 18, 2022 16:11
@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited
Loading

Codecov Report

Merging #815 (71e8304) into next (52ff017) will decrease coverage by 1.33%.
The diff coverage is 78.85%.

@@            Coverage Diff             @@
##             next     #815      +/-   ##
==========================================
- Coverage   86.32%   84.99%   -1.34%     
==========================================
  Files          51       53       +2     
  Lines        4687     4671      -16     
  Branches     1022     1010      -12     
==========================================
- Hits         4046     3970      -76     
- Misses        456      522      +66     
+ Partials      185      179       -6
Impacted Files Coverage Δ
signac/_synced_collections/__init__.py 100.00% <ø> (ø)
signac/_synced_collections/_caching.py 0.00% <0.00%> (ø)
signac/_synced_collections/backends/__init__.py 100.00% <ø> (ø)
..._synced_collections/backends/collection_mongodb.py 90.90% <ø> (ø)
...c/_synced_collections/backends/collection_redis.py 65.62% <ø> (ø)
...ac/_synced_collections/backends/collection_zarr.py 88.00% <ø> (ø)
signac/_synced_collections/buffers/__init__.py 100.00% <ø> (ø)
..._collections/buffers/memory_buffered_collection.py 100.00% <ø> (ø)
signac/_synced_collections/data_types/__init__.py 100.00% <ø> (ø)
signac/_synced_collections/data_types/attr_dict.py 100.00% <ø> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vyasr vyasr merged commit 62a9d75 into next Sep 18, 2022
@vyasr vyasr deleted the remove_warnings branch September 18, 2022 19:50
bdice pushed a commit that referenced this pull request Oct 7, 2022
@vyasr @bdice
Remove warnings module. (#815)
c5cba44 
* Remove warnings module.

* Update changelog.
bdice pushed a commit that referenced this pull request Oct 27, 2022
@vyasr @bdice
Remove warnings module. (#815)
d9355ab 
* Remove warnings module.

* Update changelog.
vyasr added a commit that referenced this pull request Oct 30, 2022
@vyasr
Remove warnings module. (#815)
9492a11 
* Remove warnings module.

* Update changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@tcmoore3 tcmoore3 Awaiting requested review from tcmoore3 tcmoore3 is a code owner automatically assigned from glotzerlab/signac-committers

@pepak13 pepak13 Awaiting requested review from pepak13 pepak13 is a code owner automatically assigned from glotzerlab/signac-contributors

Assignees

@vyasr vyasr

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vyasr @bdice