Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tfteague
Copy link
Contributor

@tfteague tfteague commented Apr 28, 2025

Description

Added the option for the user to specify the name and directory of the files output by slurm. The field still populates as before if not specified.

Motivation and context

Currently, output files are typically placed in the same directory as where the code is run, which may be undesirable depending on a given project's organization.

How has this been tested?

Unit tests were added to the workflow.rs and slurm.rs to that the output field bash file is properly instantiated based on the new options.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

@tfteague tfteague requested a review from joaander April 28, 2025 18:33
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 0fc087f into trunk Apr 29, 2025
17 checks passed
@joaander joaander deleted the add_output_path branch April 29, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants