Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@archmoj
Copy link
Collaborator

@archmoj archmoj commented Aug 18, 2020

Attempt major bumps (i.e. vX.0.0) for various dependencies without breaking node v4 support.
Caution: this PR may require additional testing.

@rreusser

@rreusser
Copy link
Member

Hmm… for a start, are you able to test this end to end (e.g. in plotly) and verify that this works all the way though? I don't currently have something on hand that makes nontrivial use of glslify to really test it out and verify with confidence that it works as expected.

@ericmorand
Copy link
Collaborator

@archmoj is the dependency major bump needed?

@archmoj
Copy link
Collaborator Author

archmoj commented Aug 18, 2020

Hmm… for a start, are you able to test this end to end (e.g. in plotly) and verify that this works all the way though? I don't currently have something on hand that makes nontrivial use of glslify to really test it out and verify with confidence that it works as expected.

Good idea. I did test it on this branch: https://github.com/plotly/plotly.js/tree/glslify-major-bumps

@archmoj
Copy link
Collaborator Author

archmoj commented Aug 18, 2020

@archmoj is the dependency major bump needed?

Not 100% sure at the moment. But this may help keeping up with the latest versions of the modules and possibly fix (& not introduce) some bugs. So this is kind of an experimental branch for now.

Also because package-lock.json for good reasons is not present on this repo, it is not clear which versions (minor/patch) were used by the test system at different times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants