Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing flash of white in dark mode #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gm3dmo merged 1 commit into from
Feb 17, 2025
Merged

Fixing flash of white in dark mode #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions powerindex/static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
function toggleTheme() {
const theme = document.documentElement.getAttribute('data-theme') === 'dark' ? 'light' : 'dark';
document.documentElement.setAttribute('data-theme', theme);
localStorage.setItem('theme', theme);
}
// Initialize theme before DOM loads
const savedTheme = localStorage.getItem('theme') || 'light';
document.documentElement.setAttribute('data-theme', savedTheme);

// Add ready class after DOM is loaded
document.addEventListener('DOMContentLoaded', () => {
// Check for saved theme preference
const savedTheme = localStorage.getItem('theme') || 'light';
document.documentElement.setAttribute('data-theme', savedTheme);

document.documentElement.classList.add('ready');

// Add click handler to logo
const logo = document.querySelector('.title-logo');
if (logo) {
logo.addEventListener('click', toggleTheme);
}
});

function toggleTheme() {
const theme = document.documentElement.getAttribute('data-theme') === 'dark' ? 'light' : 'dark';
document.documentElement.setAttribute('data-theme', theme);
localStorage.setItem('theme', theme);
}

function searchConfig() {
const input = document.getElementById('configSearch');
const filter = input.value.toLowerCase();
Expand Down
48 changes: 37 additions & 11 deletions powerindex/static/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
html {
visibility: hidden;
background-color: #1a1a1a; /* Dark mode background color */
}

html.ready {
visibility: visible;
}

[data-theme="light"] {
background-color: #f0f0f0; /* Light mode background */
}

:root {
/* Light mode colors */
--background-color: #f0f0f0;
Expand Down Expand Up @@ -385,6 +398,19 @@ tr:hover {
padding: 2px;
border-radius: 4px;
font-family: var(--monospace-font);
-webkit-tap-highlight-color: transparent;
transition: none !important;
user-select: none;
-webkit-user-select: none;
-webkit-touch-callout: none; /* Disable callout on iOS */
outline: none !important; /* Remove outline */
}

.script-item a:active,
.script-item a:focus {
background-color: transparent !important;
outline: none !important;
-webkit-tap-highlight-color: transparent !important;
}

.script-item a:hover {
Expand Down Expand Up @@ -551,21 +577,21 @@ tr:hover {
}

[data-theme="dark"] .script-item a {
color: #e0e0e0; /* Light gray color for better readability in dark mode */
color: #e0e0e0;
transition: none !important;
-webkit-tap-highlight-color: transparent;
}

[data-theme="dark"] .script-item a.selected {
color: var(--govuk-black); /* Keep the selected item text dark against yellow background */
[data-theme="dark"] .script-item a:active,
[data-theme="dark"] .script-item a:focus {
background-color: #000000 !important;
color: #e0e0e0 !important;
}

[data-theme="dark"] .script-item a:hover {
background-color: #000000; /* Changed to pure black for hover */
color: #e0e0e0;
}

[data-theme="dark"] .script-item a.selected:hover {
color: var(--govuk-black);
background-color: var(--govuk-yellow); /* Keep yellow background for selected items */
[data-theme="dark"] .script-item a.selected:active,
[data-theme="dark"] .script-item a.selected:focus {
background-color: var(--govuk-yellow) !important;
color: var(--govuk-black) !important;
}

[data-theme="dark"] .script-content h3 {
Expand Down