Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[JS->TS] Migrate get_auction_elements.js #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2020
Merged

[JS->TS] Migrate get_auction_elements.js #818

merged 2 commits into from
Jun 2, 2020

Conversation

@bh2smith
Copy link
Contributor

@bh2smith bh2smith commented May 29, 2020 •
edited
Loading

Very easy switch over. Noticed that colours weren't appearing as I would have expected in my terminal. Partial fulfillment of #330

Test Plan Take a while, but

npx truffle exec build/common/scripts/get_auction_elements.js --network rinkeby

Will print a bunch of orders and then say something like Found 1218 orders. One example order looks like

{
  user: 0x9bc7569755aab9ddb9be1aaf7b28a90565d79c06
  sellTokenBalance: 0
  buyToken: 7
  sellToken: 1
  validFrom: Mon May 25 2020 12:00:00 GMT+0200 (Central European Summer Time)
  validUntil: Thu Aug 17 42800 23:10:00 GMT+0200 (Central European Summer Time)
  price: Sell 13 * 10^35 for at least 34 * 10^37
  remaining: 13 * 10^35
}

@bh2smith bh2smith added the easy label May 29, 2020
@bh2smith bh2smith requested a review from a team May 29, 2020 08:37
fleupold
fleupold approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the easy tag. This script is arguably not that useful anymore now that fetching the orderbook via onchain state takes forever, but given you already converted it it's nice to kepp. Maybe we will reuse it one day...

scripts/get_auction_elements.ts

const printOrder = function (order: Order<BN>, currentBatchId: number) {
/* eslint-disable no-console */
console.log("{");
Copy link
Contributor

@fleupold fleupold May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this take a logger now that we have it?

Copy link
Contributor Author

@bh2smith bh2smith May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn’t look good with all of the time stamps and info. Just seems unnecessarily wide with the logger. Also can’t be copied easily... not that we would ever use it.

@bh2smith bh2smith merged commit 6521a03 into master Jun 2, 2020
@bh2smith bh2smith deleted the 330/migrate_get_auction_elements branch June 2, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fleupold fleupold fleupold approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

easy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bh2smith @fleupold