Fix VT_BOOL value conversion #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boolVal is only 16-bits wide in the C structure, but we are reading it here as a 64-bit integer. The upper bits are not necessarily initialized. This can lead to "true" being returned incorrectly when the actual value is "false". Fix the issse by masking off the upper bits before the comparison.
|
Good catch. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolVal is only 16-bits wide in the C structure, but we are reading it
here as a 64-bit integer. The upper bits are not necessarily
initialized. This can lead to "true" being returned incorrectly when the
actual value is "false".
Fix the issse by masking off the upper bits before the comparison.