Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@patilsanty
Copy link

Added support for CoInitializeSecurity api of COM, which can be used to override both computer-wide access permissions and application-specific access permissions, but not to override the computer-wide restriction policy.

@patilsanty
Copy link
Author

@mattn @jacobsantos Please review the pull request. This is required for my project in order to utilize go-ole package.

@jacobsantos
Copy link
Member

Looks okay. I looked up why the global and I am guessing it is from the notes that the function will be called no more than once. I am unable to verify the code works. I am willing to merge as it should be safe and not affect other parts of the code.

@jacobsantos
Copy link
Member

@mattn @patilsanty I think this should be safe to merge. It is unfortunate that the CI is down to verify automatically.

@patilsanty
Copy link
Author

@jacobsantos Thank you. When can the CI build will be up?

Check whether `//go:build windows` is breaking CI
@jacobsantos
Copy link
Member

@patilsanty There is an build error.

# golang.org/x/tools/internal/gocommand
c:\gopath\pkg\mod\golang.org\x\[email protected]\internal\gocommand\invoke.go:399:62: undefined: os.ErrProcessDone
note: module requires Go 1.18

it looks like the build is using Go 1.12. Please submit something that works with Go 1.12.

@jacobsantos
Copy link
Member

It is likely that the Go version can be bumped up since Go 1.12 was EOL 4 years ago. We could probably bump that to 1.18 safely given the language backwards compatibility support.

@jacobsantos
Copy link
Member

@patilsanty If you can submit something that supports Go 1.12 and that passes the CI, then we can get this merged.

@jacobsantos jacobsantos merged commit de26f2b into go-ole:master Aug 4, 2023
@jacobsantos
Copy link
Member

Passed CI check. Merging. Thanks @patilsanty

@subodh2691
Copy link

@jacobsantos Can you help me to create a tag out of this commit? I require similar changes in my codebase to work with windows snapshots, this change will help me reducing local changes in lib.

@jacobsantos
Copy link
Member

The tag would have to be 1.3.x. I don't want to mess with 1.2 since it may upgrade those on that branch.

@jacobsantos
Copy link
Member

1.3.0 has been released. Thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants