-
-
Notifications
You must be signed in to change notification settings - Fork 205
refs added code to com InitializeSecurity #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mattn @jacobsantos Please review the pull request. This is required for my project in order to utilize go-ole package. |
|
Looks okay. I looked up why the global and I am guessing it is from the notes that the function will be called no more than once. I am unable to verify the code works. I am willing to merge as it should be safe and not affect other parts of the code. |
|
@mattn @patilsanty I think this should be safe to merge. It is unfortunate that the CI is down to verify automatically. |
|
@jacobsantos Thank you. When can the CI build will be up? |
Check whether `//go:build windows` is breaking CI
|
@patilsanty There is an build error. it looks like the build is using Go 1.12. Please submit something that works with Go 1.12. |
|
It is likely that the Go version can be bumped up since Go 1.12 was EOL 4 years ago. We could probably bump that to 1.18 safely given the language backwards compatibility support. |
|
@patilsanty If you can submit something that supports Go 1.12 and that passes the CI, then we can get this merged. |
|
Passed CI check. Merging. Thanks @patilsanty |
|
@jacobsantos Can you help me to create a tag out of this commit? I require similar changes in my codebase to work with windows snapshots, this change will help me reducing local changes in lib. |
|
The tag would have to be 1.3.x. I don't want to mess with 1.2 since it may upgrade those on that branch. |
|
1.3.0 has been released. Thank you for the help! |
Added support for CoInitializeSecurity api of COM, which can be used to override both computer-wide access permissions and application-specific access permissions, but not to override the computer-wide restriction policy.