Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vladdy
Copy link
Contributor

@vladdy vladdy commented Oct 31, 2015

I'm preparing another pull request with basic instructions on how to contribute to this project and the makefile should make it easier to work with it for those who develop in command line.

@VojtechVitek
Copy link
Contributor

Even though I really like Makefiles for larger projects, I don't think it's necessary for project like chi. Is there any other simple router out there with Makefile?

We can run go build, go test or go fmt directly in the single directory. There's no hidden magic that'd require us to run make. Thoughts?

@vladdy
Copy link
Contributor Author

vladdy commented Nov 4, 2015

Yes, we can just use go commands and chi is not that big project (yet), but, for example, "make" can be set to default go build && go test && go fmt later when you notice a lot of issues with formatting and it won't be required to update the build instructions or change workflow then.

Anyway, your point also makes sense, so if you are still not sold for this workflow, just close this pull request and I'll update #8 with raw go commands.

Thanks for quick response!

@pkieltyka
Copy link
Member

@vladdy thanks for the PR, but we'd like to keep things as lean as possible.

@pkieltyka pkieltyka closed this Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants