feat(): add CF-Connecting-IP #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
reviewed
Apr 9, 2024
VojtechVitek
reviewed
Apr 9, 2024
Contributor
VojtechVitek
left a comment
There was a problem hiding this comment.
I think this is looking good. Few more suggestions.
d0d2277 to
da49574
Compare
VojtechVitek
approved these changes
Apr 9, 2024
Contributor
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM
I can test this if @pkieltyka gives it a go.
VojtechVitek
reviewed
Apr 9, 2024
pkieltyka
reviewed
Apr 9, 2024
VojtechVitek
approved these changes
Apr 9, 2024
VojtechVitek
approved these changes
Apr 9, 2024
Contributor
VojtechVitek
left a comment
There was a problem hiding this comment.
Code LGTM.
I'll give this a try and test.
VojtechVitek
approved these changes
Apr 9, 2024
Contributor
VojtechVitek
left a comment
There was a problem hiding this comment.
r.Use(middleware.RealIPFromHeaders("CF-Connecting-IP", "X-True-Client-IP", "X-Real-IP", "X-Forwarded-For"))works as expected
VojtechVitek
added a commit
that referenced
this pull request
Dec 14, 2024
This reverts commit cbaac31.
Contributor
|
This feature was reverted and never released. See #966 for more details. |
VojtechVitek
added a commit
that referenced
this pull request
Dec 14, 2024
Contributor
|
Please, have a look at this proposal: #967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.