middleware.Cancel #3
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something for consideration:
middleware.Timeout()andmiddleware.CloseNotifydon't need tocancel()the context when the underlying handlers return. We might want to use explicitmiddleware.Cancelinstead.This way, all handlers would have
context.Background()as a base context and it'd be up to developers to specify when the "context flow" ends. Timeout should only cancel underlying contexts on timeout. CloseNotify should only cancel underlying contexts on<-w.CloseNotify(). Explicit over magic.If we wanted to have strict boundaries for context lifetime in the handler chain, we'd need to use
context.WithCancel()instead ofcontext.Background()in mux.ServeHTTPC().